-
Notifications
You must be signed in to change notification settings - Fork 748
Handle Exceptions thrown during discovery, such as in Custom Attributes #4104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manfred-brands ! Great that this could be fixed so simply.
Two minor nitpicks/ suggestions. I also would appreciate a second review from someone else
src/NUnitFramework/framework/Internal/Builders/DefaultTestCaseBuilder.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/testdata/AttributeThrowingExceptionFixture.cs
Outdated
Show resolved
Hide resolved
Thanks @stevenaw, changes made. |
Very cool, thanks @manfred-brands ! Looks great to me 👍 |
Is there anything blocking this from being merged in? |
@manfred-brands I'd been hoping to get a second pair of eyes on it since this is a part of the codebase I'm less familiar with, but perhaps it could also be merged as-is. |
I'm sorry. This PR got lost in too many GitHub notifications. I'll take a look at this today or tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. This looks good. For anyone else reviewing, ignore whitespace, it is much easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've only some very minor comments 👍
src/NUnitFramework/framework/Internal/Builders/DefaultTestCaseBuilder.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Internal/Builders/NUnitTestCaseBuilder.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Internal/Builders/DefaultTestCaseBuilder.cs
Outdated
Show resolved
Hide resolved
3a231b5
to
1e09c55
Compare
1e09c55
to
77887ef
Compare
Cherry pick into master depends on #4053 |
This is ready for merge into v3.13-dev now. |
Thanks @manfred-brands ! LGTM 🎉 |
Fixes #4096
Fixes #4107
Tests with Exceptions are Marked As Invalid and show up as an Error.
Fixtures with Exceptions are non-runnable and don't show up with
dotnet test
.One alternative option would be to make a special fixture with one runable method that fails.