Enumerate enumerables to determine emptiness #4120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of the `Count` property can lead to unexpected results if the `Count` is not in sync with the enumeration. It makes sense to use the `Count` on a `ICollection` since the interface clearly connects the `Count` with the enumeration. On any `IEnumerable`, this assumption is not always correct though.
manfred-brands
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Thanks @Crown0815, changes look good with a new test case added.
|
Thanks @Crown0815 for the contribution! At a glance this looks good to me too. I hope to be able to do a proper review over the next few days |
stevenaw
approved these changes
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of the
Countproperty can lead to unexpected resultsif the
Countis not in sync with the enumeration.It makes sense to use the
Counton aICollectionsince the interfaceclearly connects the
Countwith the enumeration. On anyIEnumerable,this assumption is not always correct, though.
fixes #4111