Skip to content

add missing windows11 code#4213

Merged
jnm2 merged 5 commits intonunit:masterfrom
SimonCropp:missing-windows11-code
Oct 8, 2022
Merged

add missing windows11 code#4213
jnm2 merged 5 commits intonunit:masterfrom
SimonCropp:missing-windows11-code

Conversation

@SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Oct 7, 2022

fixes #4212

@SimonCropp SimonCropp mentioned this pull request Oct 7, 2022
Merged
jnm2
jnm2 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@jnm2 jnm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stevenaw
Copy link
Member

stevenaw commented Oct 8, 2022

Thanks @SimonCropp !
Looks like an unrelated macos failure there in CI. I can't kick that off myself from my phone, but once it passes this is good to merge

@jnm2 jnm2 merged commit cac9155 into nunit:master Oct 8, 2022
@SimonCropp SimonCropp deleted the missing-windows11-code branch October 8, 2022 23:55
@stevenaw stevenaw added this to the 4.0 milestone Oct 26, 2022
@OsirisTerje OsirisTerje mentioned this pull request May 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenaw stevenaw stevenaw approved these changes

@jnm2 jnm2 jnm2 approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

Add Windows11 support to the Platform attribute

3 participants

@SimonCropp @stevenaw @jnm2