Skip to content

Indicate that SetupFixtureAttribute should not be used on base-classes#4222

Merged
stevenaw merged 2 commits into
nunit:masterfrom
x789:issue/4158
Oct 9, 2022
Merged

Indicate that SetupFixtureAttribute should not be used on base-classes#4222
stevenaw merged 2 commits into
nunit:masterfrom
x789:issue/4158

Conversation

@x789

@x789 x789 commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

As discussed in #4158.

@x789 x789 marked this pull request as ready for review October 8, 2022 11:23

@jnm2 jnm2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@jnm2 jnm2 requested a review from stevenaw October 8, 2022 15:11

@stevenaw stevenaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @x789 !

@stevenaw stevenaw merged commit 0fd0b07 into nunit:master Oct 9, 2022
@x789 x789 deleted the issue/4158 branch October 11, 2022 19:03
@stevenaw stevenaw added this to the 4.0 milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants