Skip to content

Indicate that SetupFixtureAttribute should not be used on base-classes #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2022
Merged

Indicate that SetupFixtureAttribute should not be used on base-classes #4222

merged 2 commits into from
Oct 9, 2022

Conversation

x789
Copy link
Contributor

@x789 x789 commented Oct 8, 2022

As discussed in #4158.

@x789 x789 marked this pull request as ready for review October 8, 2022 11:23
jnm2
jnm2 approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@jnm2 jnm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@jnm2 jnm2 requested a review from stevenaw October 8, 2022 15:11
stevenaw
stevenaw approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @x789 !

@stevenaw stevenaw merged commit 0fd0b07 into nunit:master Oct 9, 2022
@x789 x789 deleted the issue/4158 branch October 11, 2022 19:03
@stevenaw stevenaw added this to the 4.0 milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenaw stevenaw stevenaw approved these changes

@jnm2 jnm2 jnm2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@x789 @stevenaw @jnm2