Indicate that SetupFixtureAttribute should not be used on base-classes#4223
Merged
Conversation
x789
marked this pull request as ready for review
October 8, 2022 11:23
jnm2
approved these changes
Oct 8, 2022
Contributor
|
The build failures are because the |
stevenaw
approved these changes
Oct 9, 2022
stevenaw
left a comment
stevenaw
left a comment
Member
There was a problem hiding this comment.
Thanks!
I'm a little puzzled by the build failures myself though they're definitely not related to your changes. Will take a bit of digging to sort out
Contributor
Author
|
@mikkelbu gave a hint how to fix the |
Member
Contributor
|
Maybe we don't need that package reference at all? Eventually it'll be bringing the package version backwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #4158. This PR contains the changes for NUnit v3.