.NET 7.0 support by KonH · Pull Request #4224 · nunit/nunit

KonH · 2022-10-08T20:52:30Z

Changes required to support .NET 7.0
Work in progress, .NET 7.0 RC should be changed when a stable version is released
Related (and more details provided) to #4170

Mostly based on nunit@6cbe01e

Based on nunit@6cbe01e

…e Pipelines - nunit#4170

stevenaw · 2022-10-24T01:33:21Z

      <group targetFramework="net6.0">
        <dependency id="NUnit" version="[$version$]" />
      </group>
+      <group targetFramework="net7.0">


@manfred-brands Wondering if I can ask your confirmation of my understanding here since you did the previous upgrades in this area. This would apply to the framework of the consuming app I think, right?

@stevenaw If the app consuming nunitlite targets any of the listed framework, it will automatically add a transient dependency on the packages listed here.

stevenaw · 2022-10-24T01:39:50Z

Thanks for your hard work on working through some of the issues on this @KonH . As you mention, this won't be able to be merged until after Hacktoberfestt is complete so I've added the hacktoberfest-accepted label as requested 🙂
I've asked for a bit of help confirming the changes given we have some other team members with more previous experience in this area of the codebase, though the changeset certainly appears consistent with previous net5/6 upgrade PRs.

manfred-brands · 2022-10-24T02:20:16Z

+#if NET7_0_OR_GREATER
+        [TestCase(nameof(WarningFixture.WarningInThreadPoolQueueUserWorkItem), 4, ExcludePlatform = "MacOSX")]
+        [TestCase(nameof(WarningFixture.WarningInThreadPoolQueueUserWorkItem), 5, IncludePlatform = "MacOSX")]
+#else


Is this because of "InvokeStub_" lines not removed here?

Not exactly, I described it here - #4170 (comment)

manfred-brands

Some small suggestions, otherwise it looks good to me.

nunit#4224 (comment)

KonH · 2022-11-08T21:00:23Z

.NET 7 was released, and final changes applied

KonH · 2022-11-08T21:17:22Z

The latest fail looks flaky, the previous run completed successfully and changes between them are not related.
The log shows this line in failed run:

1) Cancelled : NUnit.Framework.Constraints.CollectionEquivalentConstraintTests.LargeStringCollection
Test cancelled by user
  at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone (NUnit.Framework.Internal.TestExecutionContext context, System.Action action) [0x0002f] in <8a6beb3f2b6c4711aa41176b631ad128>:0 
  at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.Execute (NUnit.Framework.Internal.TestExecutionContext context) [0x00060] in <8a6beb3f2b6c4711aa41176b631ad128>:0 
  at NUnit.Framework.Internal.Execution.SimpleWorkItem+<>c__DisplayClass3_0.<PerformWork>b__0 () [0x00011] in <8a6beb3f2b6c4711aa41176b631ad128>:0 
  at NUnit.Framework.Internal.ContextUtils+<>c__DisplayClass1_0`1[T].<DoIsolated>b__0 (System.Object _) [0x00000] in <8a6beb3f2b6c4711aa41176b631ad128>:0 
  at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00071] in <bab7d1a00376483b944db50cdc31e41d>:0 
  at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <bab7d1a00376483b944db50cdc31e41d>:0 
  at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state) [0x0002b] in <bab7d1a00376483b944db50cdc31e41d>:0 
  at NUnit.Framework.Internal.ContextUtils.DoIsolated (System.Threading.ContextCallback callback, System.Object state) [0x00025] in <8a6beb3f2b6c4711aa41176b631ad128>:0 
  at NUnit.Framework.Internal.ContextUtils.DoIsolated[T] (System.Func`1[TResult] func) [0x0001a] in <8a6beb3f2b6c4711aa41176b631ad128>:0 
  at NUnit.Framework.Internal.Execution.SimpleWorkItem.PerformWork () [0x0001b] in <8a6beb3f2b6c4711aa41176b631ad128>:0

stevenaw · 2022-11-12T19:32:40Z

Thanks @KonH I've pulled the changes and they run + pass fine locally for me.
As far as the failing test, you are right this one has had a history of occasionally exceeding the timeout in CI.

@nunit/framework-team This failing test was also a confusing issue for contributors during Hacktoberfest. Are there any objections to @KonH temporarily bumping up this value until it can be investigated? Perhaps just the one LargeStringCollection() test here can have the "FAIL_TIME" multiplied by 2: `https://github.com/nunit/nunit/blob/master/src/NUnitFramework/tests/Constraints/CollectionEquivalentConstraintTests.cs#L368 as the generic versions still seem under the threshold

KonH · 2022-11-12T20:05:03Z

@stevenaw I have increased timeout, now tests passed

stevenaw

LGTM thanks for your contribution @KonH

* Initial changes to support .NET 7 RC - #4170 Mostly based on 6cbe01e * NuGet packaging changes to support .NET 7 RC - #4170 Based on 6cbe01e * Continuous integration changes to support .NET 7 RC - #4170 Based on 6cbe01e * Try to fix .NET 7.0 lookup on Azure Pipelines - #4170 * It looks like we need both .NET 6.0 and .NET 7.0 to run tests on Azure Pipelines - #4170 * Use valid version for .NET 6.0 on Azure Pipelines - #4170 * Use different test settings for .NET 7 to cover corner-case - #4170 * Add potential workaround for flaky test behaviour on .NET 7 - #4170 * On MacOS test behaviour is different on .NET 7 - #4170 * Change setup-dotnet action version (for new lines only) #4224 (comment) * Use release version of .NET 7.0 * Refactor: do not copy collections, use single method * Temporary increase test timeout * Temporary increase test timeout #2

KonH added 9 commits October 8, 2022 22:43

Initial changes to support .NET 7 RC - nunit#4170

3b4d91b

Mostly based on nunit@6cbe01e

NuGet packaging changes to support .NET 7 RC - nunit#4170

5872a23

Based on nunit@6cbe01e

Continuous integration changes to support .NET 7 RC - nunit#4170

59feee9

Based on nunit@6cbe01e

Try to fix .NET 7.0 lookup on Azure Pipelines - nunit#4170

1ab5ed1

It looks like we need both .NET 6.0 and .NET 7.0 to run tests on Azur…

f36e27d

…e Pipelines - nunit#4170

Use valid version for .NET 6.0 on Azure Pipelines - nunit#4170

a8e7b81

Use different test settings for .NET 7 to cover corner-case - nunit#4170

6ac936d

Add potential workaround for flaky test behaviour on .NET 7 - nunit#4170

474571f

On MacOS test behaviour is different on .NET 7 - nunit#4170

7c6129c

stevenaw reviewed Oct 24, 2022

View reviewed changes

Comment thread src/NUnitFramework/nunitlite.tests/TextUIReportTests.cs

stevenaw reviewed Oct 24, 2022

View reviewed changes

stevenaw added the hacktoberfest-accepted label Oct 24, 2022

manfred-brands reviewed Oct 24, 2022

View reviewed changes

Comment thread .github/workflows/continuous_integration.yml

manfred-brands reviewed Oct 24, 2022

View reviewed changes

KonH added 3 commits October 26, 2022 20:06

Change setup-dotnet action version (for new lines only)

ce514ab

nunit#4224 (comment)

Use release version of .NET 7.0

30baf87

Refactor: do not copy collections, use single method

33d0787

KonH marked this pull request as ready for review November 8, 2022 21:00

KonH added 2 commits November 12, 2022 20:47

Temporary increase test timeout

157f7b2

Temporary increase test timeout nunit#2

87de946

stevenaw mentioned this pull request Nov 14, 2022

Improve performance of equivalency, superset, and subset constraints for homogenous collections #4254

Closed

stevenaw approved these changes Nov 14, 2022

View reviewed changes

stevenaw merged commit 14f2d35 into nunit:master Nov 14, 2022

stevenaw mentioned this pull request Feb 26, 2023

Backport PR#4224 onto v3.13.x (Add .NET7 as a build target for the test suite) #4302

Merged

stevenaw mentioned this pull request Oct 15, 2023

Add NET8 target for the framework tests #4503

Closed

Navigation Menu

Uh oh!

.NET 7.0 support - #4224

.NET 7.0 support#4224
stevenaw merged 14 commits into
nunit:masterfrom
KonH:feature/net7.0_support

KonH commented Oct 8, 2022

Uh oh!

Uh oh!

stevenaw Oct 24, 2022

Uh oh!

manfred-brands Oct 24, 2022

Uh oh!

stevenaw commented Oct 24, 2022

Uh oh!

manfred-brands Oct 24, 2022

Uh oh!

KonH Oct 26, 2022

Uh oh!

Uh oh!

manfred-brands left a comment

Uh oh!

KonH commented Nov 8, 2022

Uh oh!

KonH commented Nov 8, 2022

Uh oh!

stevenaw commented Nov 12, 2022

Uh oh!

KonH commented Nov 12, 2022

Uh oh!

stevenaw left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

KonH commented Oct 8, 2022

Uh oh!

Uh oh!

stevenaw Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

manfred-brands Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

stevenaw commented Oct 24, 2022

Uh oh!

manfred-brands Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

KonH Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

manfred-brands left a comment

Choose a reason for hiding this comment

Uh oh!

KonH commented Nov 8, 2022

Uh oh!

KonH commented Nov 8, 2022

Uh oh!

stevenaw commented Nov 12, 2022

Uh oh!

KonH commented Nov 12, 2022

Uh oh!

stevenaw left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants