Add TestMetadataCache to improve CompositeWorkItem build speed

[lahma]

Addresses high memory usage reported in #3858 . Adds TestCache the same way there is MethodInfoCache and caches the action attributes just like in method info cache - other cached items could be added later if needed.

BenchmarkDotNet=v0.13.5, OS=Windows 11 (10.0.22621.1343/22H2/2022Update/SunValley2)
AMD Ryzen 9 5950X, 1 CPU, 32 logical and 16 physical cores
.NET SDK=6.0.114
  [Host]     : .NET 6.0.14 (6.0.1423.7309), X64 RyuJIT AVX2
  DefaultJob : .NET 6.0.14 (6.0.1423.7309), X64 RyuJIT AVX2

Before

Method	Mean	Error	StdDev	Gen0	Gen1	Gen2	Allocated
TestActionUsage	161.4 ms	3.19 ms	5.76 ms	750.0000	500.0000	500.0000	386.22 MB

After

Method	Mean	Error	StdDev	Gen0	Gen1	Allocated
TestActionUsage	8.975 ms	0.1141 ms	0.1068 ms	281.2500	140.6250	4.71 MB

[mikkelbu]

Thanks for providing this @lahma. I'm a bit tired today, so I cannot determine if we will run into some of the same problems as we did for the other cache - see e.g. #4104 for the solution.

I'll need to examine this some more

[lahma]

Thanks for providing this @lahma. I'm a bit tired today, so I cannot determine if we will run into some of the same problems as we did for the other cache - see e.g. #4104 for the solution.

Thanks for the review. At least in this case the usage in in single point so if the attribute fails at first use it should throw at that point. Consecutive calls of course get the cached value but like discussed in one of the threads that kind of stateful attribute usage would be considered invalid.

[OsirisTerje]

@mikkelbu Have you had time to look into this? Would be nice to have it merged in.

[SimonCropp]

why is this targeting v3. given we are prepping for v4, i would think this could target master?

[lahma]

I've changed this to target master.

[stevenaw]

Thanks for rebasing this and resolving conflicts @lahma . You were too quick for me to ask. 😁

[lahma]

Now worries it was my pleasure, I like the pace that things are going into master 👍🏻

[manfred-brands]

Nice work, more caching.

A few minor comments added.

This does change the behaviour of the actions, but only for badly designed ones that don't put re-initialize stuff in the BeforeTest method. More an item to mention in any release notes.

[lahma]

@manfred-brands I've done the fixes you requested, I squashed to single commit keep cleaner, PR title and commit text now reflect the new name TestMetadataCache.

[manfred-brands]

Thanks for the quick reaction. Nothing more from me

[OsirisTerje]

Ok, so we can merge @manfred-brands ?

[manfred-brands]

@OsirisTerje I was sitting in the bus when @lahma made his latest changes. Merged now.

[OsirisTerje]

Awesome!