Add support for the ref and in keywords in ValuesAttribute - #4304
Merged
Conversation
|
|
stevenaw
self-requested a review
March 23, 2023 23:32
stevenaw
approved these changes
Mar 24, 2023
stevenaw
left a comment
stevenaw
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for your contribution @sdelarosbil ! Appreciate your writing some tests for the change too. Sorry it's taken a few weeks to get to this review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #3872
It should allow for
ref,ref?,inandin?types to be used with the parameterless version of the attribute for both bool and enum types.