ThatAsync and MultipleAsync - #4322
Merged
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
Member
OsirisTerje
approved these changes
Apr 6, 2023
OsirisTerje
left a comment
Member
There was a problem hiding this comment.
LGTM
And this is additions, nothing existing is changed, afaic see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because #2843 and #3432 made me sad.
This introduces
Assert.ThatAsync(which acceptsIsorThrowsconstraints as usual) andAssert.MultipleAsync(which can contain bothThatAsyncand synchronous assertions), and does all the right things with them (at least as far as the test method boundary), provided that youawaitthem inside anasync Tasktest.Not included, but I was pondering whether it might be a good idea: constraint
Is.Canceledand/orThrows.Canceledwhich is equivalent toThrows.InstanceOf<OperationCanceledException>().