Add NUnit.Analyzer to nunit.framework.tests#4366
Merged
Merged
Conversation
OsirisTerje
approved these changes
Apr 25, 2023
OsirisTerje
left a comment
OsirisTerje
left a comment
Member
There was a problem hiding this comment.
Awesome Job!
Looked through the top 30%, then just skimmed the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4364
Fixes #4365
Convert appropriate classic Assert to Constraints except in the area explicitly testing those classic Assertions.