Consistently use 'is null' and 'is not null' iso '== null' and '!= null'#4379
Merged
Conversation
mikkelbu
approved these changes
May 5, 2023
mikkelbu
left a comment
mikkelbu
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this @manfred-brands. I only have some nit-picks (mostly relating to the formatting of ternary expressions after the update) - otherwise it looks good.
| return 0; | ||
|
|
||
| if (x == null || y == null) | ||
| if (x is null || y is null) |
Member
There was a problem hiding this comment.
Unrelated to your change, but this is an odd (read: wrong) IComparer
| static readonly RuntimeType currentRuntime = | ||
| Type.GetType("Mono.Runtime", false) != null | ||
| ? RuntimeType.Mono | ||
| Type.GetType("Mono.Runtime", false) is not null ? RuntimeType.Mono |
Member
There was a problem hiding this comment.
Suggested change
| Type.GetType("Mono.Runtime", false) is not null ? RuntimeType.Mono | |
| Type.GetType("Mono.Runtime", false) is not null | |
| ? RuntimeType.Mono |
|
|
||
| var testFile = _testAssembly != null | ||
| ? AssemblyHelper.GetAssemblyPath(_testAssembly) | ||
| var testFile = _testAssembly is not null ? AssemblyHelper.GetAssemblyPath(_testAssembly) |
Member
There was a problem hiding this comment.
Suggested change
| var testFile = _testAssembly is not null ? AssemblyHelper.GetAssemblyPath(_testAssembly) | |
| var testFile = _testAssembly is not null | |
| ? AssemblyHelper.GetAssemblyPath(_testAssembly) |
| ? _testAssembly.GetName().Name | ||
| : _options.InputFile != null | ||
| ? Path.GetFileNameWithoutExtension(_options.InputFile) | ||
| var baseName = _testAssembly is not null ? _testAssembly.GetName().Name |
Member
There was a problem hiding this comment.
I think we should keep the existing formatting
Member
Author
There was a problem hiding this comment.
I certainly agree, it seems the CodeFix from the Analyzer looses trailing trivia. I will create an issue (and PR) for it: AArnott/CSharpIsNull#45
| { | ||
| string display = arg == null | ||
| ? "null" | ||
| string display = arg is null ? "null" |
Member
There was a problem hiding this comment.
Suggested change
| string display = arg is null ? "null" | |
| string display = arg is null | |
| ? "null" |
| { | ||
| return Assembly != null | ||
| ? Assembly.GetAttributes<TAttr>() | ||
| return Assembly is not null ? Assembly.GetAttributes<TAttr>() |
Member
There was a problem hiding this comment.
Suggested change
| return Assembly is not null ? Assembly.GetAttributes<TAttr>() | |
| return Assembly is not null | |
| ? Assembly.GetAttributes<TAttr>() |
| { | ||
| Event? e = _events.Dequeue( PumpState == EventPumpState.Pumping ); | ||
| if ( e == null ) | ||
| if ( e is null) |
Member
There was a problem hiding this comment.
Suggested change
| if ( e is null) | |
| if (e is null) |
|
|
||
| return tail != null | ||
| ? ApplySelection(resultNodes, tail) | ||
| return tail is not null ? ApplySelection(resultNodes, tail) |
Member
There was a problem hiding this comment.
Suggested change
| return tail is not null ? ApplySelection(resultNodes, tail) | |
| return tail is not null | |
| ? ApplySelection(resultNodes, tail) |
| // 2. User provided an ITestCaseData and we just use it. | ||
| ITestCaseData? parms = item == null | ||
| ? new TestCaseParameters(new object?[] { null }) | ||
| ITestCaseData? parms = item is null ? new TestCaseParameters(new object?[] { null }) |
Member
There was a problem hiding this comment.
Suggested change
| ITestCaseData? parms = item is null ? new TestCaseParameters(new object?[] { null }) | |
| ITestCaseData? parms = item is null | |
| ? new TestCaseParameters(new object?[] { null }) |
Member
Author
|
@mikkelbu I have fixed the CSharpIsNullAnalyzer CodeFix (locally) and re-applied the codefix. Now the existing formatting has been kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4378