Skip to content

Remove partial trust support #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

stevenaw
Copy link
Member

Fixes #3301

This largely was a find-remove of the following attributes usage and comments without much else needed.

  • SecurityCriticalAttribute
  • SecuritySafeCriticalAttribute
  • AllowPartiallyTrustedCallers

The LowTrustFixture tests were updated to now expect a MemberAccessException to be thrown as a way of verifying we continue to not support partial trust, though I'm on the fence about removing them outright.

@stevenaw stevenaw added this to the 4.0 milestone May 31, 2023
Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenaw
Copy link
Member Author

stevenaw commented Jun 3, 2023

Thanks!

@stevenaw stevenaw merged commit d22be76 into nunit:master Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HandleProcessCorruptedStateExceptions] has no effect unless we disable partial trust
2 participants