Issue4416

[OsirisTerje]

Resolving #4416

[manfred-brands]

I have fixed some of the items mentioned:
Enabled warnings for formatting violations and fixed code.
Added Assert.cs class
Enabled Assert.Conditions.cs. Note that there no longer seem to be unit test for these (probably all converted to Assert.That).

Let me know if you want me to do some more work for you.

[OsirisTerje]

@manfred-brands

@OsirisTerje I think our tests are to verbose in general. With all the output it is hard to find if/where there is an error.
When running tests in VS yesterday, I noticed lots of output from Assume expected True but was False

Some of these comes from platform dependent tests. I believe we could use the Platform attribute instead to get rid of these.
Some comes from Theory based tests, but I don't understand why the tests are made that way. It is just confusing.

I notice that the tests are still visible in the Test Explorer, but I thought that #3866 should remove them?

[UPDATE]
The results coming back from these tests are either Skipped (Platform stuff and Explicit) or Inconclusive (Theory and other Assumes). It's possibly best to let these pass through to the output as they do now, but they could be optionally filtered in the adapter. That's an easy place to do so, and would fix both dotnet test and Visual Studio.
In the VS Test Explorer you can already now filter these off there, by selecting only Green and Red tests, but it would be nice to get them off the CI builds, as you say - they are too verbose and hard to interpret.
It would also help to actually see explicitly that result comes from an Assume. Now it can be inferred by seeing that they do give a result and at the same time is Inconclusive, --- but Test Explorer only says it is Not Run.
When we get the CAE, this will be more visible.

[mikkelbu]

Regarding the inconclusive tests, then it has been an issue for a long time - see e.g. #1001

[OsirisTerje]

Awesome, thanks @mikkelbu ! I was not aware of that one. I think we can actually handle this in the adapter, and and then turn those off in a .runsettings.