Add Copyright and licence notices for third-party code#4444
Conversation
|
|
||
| | Reference | Version | License Type | License | | ||
| |--------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | Microsoft.NET.Test.Sdk | 17.6.3 | LICENSE_NET.txt | https://www.nuget.org/packages/Microsoft.NET.Test.Sdk/17.6.3/License | |
There was a problem hiding this comment.
This file is being updated very often. Could be wise to include a comment that it applies to this version and subsequent versions.
There was a problem hiding this comment.
Alternatively, maybe changing the link to the license file in their GitHub repo (https://github.com/microsoft/vstest/blob/main/LICENSE)?
|
@lennartb- Appreciate the work here! |
… one for development-only projects
| | IsExternalInit | 1.0.3 | MIT | https://licenses.nuget.org/MIT | | ||
| | Microsoft.Win32.Registry | 5.0.0 | MIT | https://licenses.nuget.org/MIT | | ||
| | Nullable | 1.3.1 | MIT | https://licenses.nuget.org/MIT | | ||
| | System.Runtime.Loader | 4.3.0 | MS-EULA | http://go.microsoft.com/fwlink/?LinkId=329770 | | ||
| | TunnelVisionLabs.ReferenceAssemblyAnnotator | 1.0.0-alpha.160 | MIT | https://licenses.nuget.org/MIT | |
There was a problem hiding this comment.
These are license notices; are the copyright notices also included? For some packages, there may be copyright notices in the version resources of DLL files, but I think not for IsExternalInit whose package contains source code instead.
There was a problem hiding this comment.
@KalleOlaviNiemitalo This PR is already merged. Suggest you raise another PR to add the copyright notices where applicable :-)
5 participants
Fixes #3869
I used the regex
^(?!.*charlie poole).*copyright.*$to find all files with copyright notices except those from NUnit, which were, as noted in the original issue, only present inOptions.cs.I also omitted the NUnit-specific packages from the third-party notices.
Let me know if there's anything I missed, or you want differently.