Add the ability to use params arguments properly when using a parametrised test fixture - #4478
Conversation
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @Shiney for your contribution.
I only have a few small comments.
|
Hi @manfred-brands I tried to do your comments about swapping the order of the checks but it didn't seem to end up making the code much nicer in my opinion because it ended up having to do all sorts of extra special code to deal with the case where zero parameters provided were used for the params argument |
|
@Shiney I tried to push my review changes, but you didn't allow maintainers to update the fork. |
|
Yes will do this soon |
|
I believe I've fixed all the comments and have ticked the Allow edits by maintainers button just in case |
…s edge cases not covered
Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
7efb8b0 to
fc98d9d
Compare
|
Thanks @Shiney. I have fixed some spacing issues as earlier this week we enabled enforcing these rules. |
Added some tests for this and made the methods that call the constructors on TestFixtures able to allow params arguments. This doesn't really address the duplication with similar code for calling test methods but that didn't seem particularly quick to also fix as part of this.
Fixes #1459