Skip to content

Add the ability to use params arguments properly when using a parametrised test fixture #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 14, 2023

Conversation

Shiney
Copy link
Contributor

@Shiney Shiney commented Oct 2, 2023

Added some tests for this and made the methods that call the constructors on TestFixtures able to allow params arguments. This doesn't really address the duplication with similar code for calling test methods but that didn't seem particularly quick to also fix as part of this.

Fixes #1459

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shiney for your contribution.
I only have a few small comments.

@Shiney
Copy link
Contributor Author

Shiney commented Oct 9, 2023

Hi @manfred-brands I tried to do your comments about swapping the order of the checks but it didn't seem to end up making the code much nicer in my opinion because it ended up having to do all sorts of extra special code to deal with the case where zero parameters provided were used for the params argument

@manfred-brands
Copy link
Member

@Shiney I tried to push my review changes, but you didn't allow maintainers to update the fork.
Could you please address the other outstanding issues.

@Shiney
Copy link
Contributor Author

Shiney commented Oct 12, 2023

Yes will do this soon

@Shiney
Copy link
Contributor Author

Shiney commented Oct 14, 2023

I believe I've fixed all the comments and have ticked the Allow edits by maintainers button just in case

@manfred-brands
Copy link
Member

Thanks @Shiney. I have fixed some spacing issues as earlier this week we enabled enforcing these rules.

@manfred-brands manfred-brands self-requested a review October 14, 2023 09:22
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing further.

@OsirisTerje OsirisTerje merged commit 18ddf7c into nunit:master Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for params keyword in parameterized test fixtures
3 participants