Enable equality/inequality constraints against non-seekable steams #4483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the inequality tests, I made the expected and actual streams of the same size. I can double-up each inequality test where the stream lengths aren't equal, let me know if it's worth it. Same with streams whose contents exceed the |
stevenaw
reviewed
Oct 8, 2023
| if (xStream.Length != yStream.Length) return false; | ||
| bool bothSeekable = xStream.CanSeek && yStream.CanSeek; | ||
|
|
||
| if (bothSeekable && xStream.Length != yStream.Length) return false; |
There was a problem hiding this comment.
Thanks, this is a nice early bailout optimization
stevenaw
approved these changes
Oct 8, 2023
There was a problem hiding this comment.
Thanks @RenderMichael this looks great! I've pulled the changes and they work great. I also can't seem to find any edge cases you haven't already accounted for :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4476
Instead of using the stream's length as a stopping condition, we check that the amount of bytes read in the previous read operation is greater than 0.