Skip to content

Fixes #2841 #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2023
Merged

Fixes #2841 #4488

merged 5 commits into from
Oct 15, 2023

Conversation

OsirisTerje
Copy link
Member

Added fix from @mikkelbu, comment #2841 (comment)
Added test to verify it

@OsirisTerje OsirisTerje requested a review from mikkelbu October 9, 2023 21:24
@OsirisTerje OsirisTerje mentioned this pull request Oct 9, 2023
Closed
@OsirisTerje
Copy link
Member Author

MacOS wasnt happy with the test:

1) Failed : NUnit.Framework.Tests.Constraints.DelayedConstraintTests.ThatPollingCallsDelegateCorrectNumberOfTimes
  Assert.That(PollCount, Is.EqualTo(4).After(100, 25))
  Expected: 4 after 100 milliseconds delay
  But was:  3
   at NUnit.Framework.Tests.Constraints.DelayedConstraintTests.ThatPollingCallsDelegateCorrectNumberOfTimes() in /Users/runner/work/nunit/nunit/src/NUnitFramework/tests/Constraints/DelayedConstraintTests.cs:line 241

manfred-brands
manfred-brands approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is correct, I only have a suggestion to simplify the code.
And adding a check on pollingIntervalInMilliseconds > 0 would be nice.

mikkelbu
mikkelbu approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OsirisTerje OsirisTerje merged commit 43aba69 into master Oct 15, 2023
@OsirisTerje OsirisTerje deleted the Issue2841 branch October 15, 2023 08:49
@manfred-brands manfred-brands mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manfred-brands manfred-brands manfred-brands approved these changes

@mikkelbu mikkelbu mikkelbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OsirisTerje @mikkelbu @manfred-brands