Skip to content

Issue 4450 fix#4502

Merged
OsirisTerje merged 4 commits into
nunit:masterfrom
ashishdawale20:issue-4450-fix
Oct 15, 2023
Merged

Issue 4450 fix#4502
OsirisTerje merged 4 commits into
nunit:masterfrom
ashishdawale20:issue-4450-fix

Conversation

@ashishdawale20

Copy link
Copy Markdown
Contributor

This PR should fix issue #4450

@manfred-brands manfred-brands left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashishdawale20 for this PR.
This makes the error message for collections of strings much clearer.

Comment thread src/NUnitFramework/tests/Assertions/ArrayEqualsFailureMessageFixture.cs Outdated
@stevenaw

Copy link
Copy Markdown
Member

@OsirisTerje @manfred-brands
I've noticed a few of the appveyor status checks stalling across PRs. I haven't looked into it myself yet, but is this a known issue or something that needs investigation?

@manfred-brands

Copy link
Copy Markdown
Member

I had noticed it as well and had sent @OsirisTerje an email. It prevents me from merging otherwise approved PRs.

@OsirisTerje

Copy link
Copy Markdown
Member

We should just remove the appveyor build. I have been just ignoring them. You can still merge even if the appveyor build stops.

@manfred-brands

Copy link
Copy Markdown
Member

We should just remove the appveyor build. I have been just ignoring them. You can still merge even if the appveyor build stops.

I can't, it says Required statuses must pass before merging

@OsirisTerje

Copy link
Copy Markdown
Member

Ok, then we just remove appveyor asap. Raised issue #4504

@OsirisTerje OsirisTerje merged commit 2521f87 into nunit:master Oct 15, 2023
@OsirisTerje

Copy link
Copy Markdown
Member

I have also removed the appveyor builds from the branch protection rules, so it should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants