.NET 8 support

[ashishdawale20]

Changes required to support .NET 8.0 #4503
Work in progress, .NET8.0 RC should be changed when a stable version is released and few tests are are failing will take a look at that as well.

[manfred-brands]

BinarySerialization is no longer supported in .NET 8. due to security concerns

Do we make it conditional, or shall we remove it from NUnit4 completely?

[manfred-brands]

@ashishdawale20 you need to update .git/workflows/continuous_integration.yml to install .net 8.0:
You can combine all into one step:

    - name: Setup .NET
      uses: actions/setup-dotnet@v3
      with:
        dotnet-version: |
          6.0.x
          7.0.x
          8.0.100-rc.2.23502.2

[stevenaw]

Do we make it conditional, or shall we remove it from NUnit4 completely?

Last I checked (also on mobile), this is only used for one constraint so it might mean dropping support for that constraint on non-netfx builds. I'm ok with this myself.

EDIT: Though perhaps within this PR we just wrap the test within an #if !NET8_ORGREATER block?

[ashishdawale20]

@ashishdawale20 you need to update .git/workflows/continuous_integration.yml to install .net 8.0: You can combine all into one step:

    - name: Setup .NET
      uses: actions/setup-dotnet@v3
      with:
        dotnet-version: |
          6.0.x
          7.0.x
          8.0.100-rc.2.23502.2

Thank you @manfred-brands - this is done, i will check why github action is failing to setup .net

[manfred-brands]

dotnet cake doesn't want to run, not even locally.

[manfred-brands]

@ashishdawale20 Have you compiled the source locally?

There are two compile errors due to obsolete code.

[ashishdawale20]

@ashishdawale20 Have you compiled the source locally?

There are two compile errors due to obsolete code.

Yes @manfred-brands , it works for me locally

[manfred-brands]

I think you have the same 'warnings':

When building inside Visual Studio they are allowed, when building with dotnet build they become errors.

[OsirisTerje]

@stevenaw Which constraint is it impacting?

[manfred-brands]

@stevenaw Which constraint is it impacting?

BinarySerializableConstraint

It was already obsolete in .NET6.0, but it got physically removed in .NET8.0, breaking the tests.

[OsirisTerje]

Do we make it conditional, or shall we remove it from NUnit4 completely?

Imho, remove it completely. The 4.0 is the good one for breaking changes.
We also must update the docs on it.

[ashishdawale20]

BinarySerializableConstraint

@OsirisTerje - i have created this PR for doc update : nunit/docs#814

[manfred-brands]

The build seems to suffer from the .NET 8.0 RC2 dotnet tool bug](dotnet/sdk#35989)

[manfred-brands]

@OsirisTerje Updated to final release of .NET8.0 SDK

[OsirisTerje]

Directory.Build.Props: The runtimeframeworks is defined there, and missing net8, but includes net7. Since testing for net7 is replaced with net8 we could remove net7.

[manfred-brands]

Directory.Build.Props: The runtimeframeworks is defined there, and missing net8, but includes net7. Since testing for net7 is replaced with net8 we could remove net7.

It contains: <NUnitRuntimeFrameworks>net462;net6.0;net8.0</NUnitRuntimeFrameworks>

[OsirisTerje]

@manfred-brands Nice. But, should we then remove .net 7 from wherever that is used?

[OsirisTerje]

Awesome!

[manfred-brands]

@manfred-brands Nice. But, should we then remove .net 7 from wherever that is used?

I just removed it from the places you found.
There is some conditional code on NET7_0_OR_GREATER which I would like to stay as that is the SDK where that feature was introduced.

[OsirisTerje]

We'll then push out a beta.2 , but I was planning for doing a non-beta release of 4 by the end of the week.