Skip to content

Allow null string message to be passed to Assert.That#4533

Merged
manfred-brands merged 1 commit into
nunit:masterfrom
manfred-brands:Issue4532_NullMessage
Oct 31, 2023
Merged

Allow null string message to be passed to Assert.That#4533
manfred-brands merged 1 commit into
nunit:masterfrom
manfred-brands:Issue4532_NullMessage

Conversation

@manfred-brands

Copy link
Copy Markdown
Member

Fixes #4532

@stevenaw stevenaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch @manfred-brands

@manfred-brands

Copy link
Copy Markdown
Member Author

LGTM. Good catch @manfred-brands

I only noticed it because some my work's NUnit extensions didn't compile anymore with version 4.

@manfred-brands manfred-brands merged commit afeef7c into nunit:master Oct 31, 2023
@manfred-brands manfred-brands deleted the Issue4532_NullMessage branch October 31, 2023 10:44
@OsirisTerje

Copy link
Copy Markdown
Member

@manfred-brands Awesome! Very good that you found this before real release. The more we manage to test the beta, the more likely it is we wont have any hotfixes.

@manfred-brands

Copy link
Copy Markdown
Member Author

@OsirisTerje I'm still at the 'compile' phase. I thought I had the big repository all done, but then the tests failed with missing methods because the NUnitExtensions we have were still trying to resolve NUnit3 signatures of Assert.That. So next step is to update those libraries.

@OsirisTerje

Copy link
Copy Markdown
Member

@manfred-brands Could be interesting if you wrote up your experiences, could be useful for creating a migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assert.That no longer allows 'null' message

3 participants