Updated cake to version 3.1.0 and corrected breaking changes cake code #4540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manfred-brands
requested changes
Nov 7, 2023
src/NUnitFramework/tests/Constraints/CollectionEquivalentConstraintTests.cs
Outdated
Show resolved
Hide resolved
Fix requested changes
manfred-brands
approved these changes
Nov 8, 2023
stevenaw
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Thanks @OsirisTerje , especially for the added macos fix. Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While correcting the script after the update, I noticed that we do have some tasks that seems to not be used, Publish Test results is one - that one seems to be oriented to Azure Pipelines. And then SignPackages. This one I believed we should have there, but I guess we might need to update it, and also ensure we have a valid certificate.
On the other hand, nuget does an automatic repository signing for the packages. So, do we need more?
Fixes #4465