Skip to content

Fix .nuspec dependency for .NET build#4582

Merged
stevenaw merged 1 commit into
nunit:masterfrom
manfred-brands:issue4581_nuspec
Dec 7, 2023
Merged

Fix .nuspec dependency for .NET build#4582
stevenaw merged 1 commit into
nunit:masterfrom
manfred-brands:issue4581_nuspec

Conversation

@manfred-brands

Copy link
Copy Markdown
Member

Fixes #4581

We cannot really test this in the repository as it depends on the nuget package being created.

The below shows the problem.
Recompiling with an .nupkg resulting from this branch causes it to work.

nunit-issue4581-tests.zip

@stevenaw stevenaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenaw stevenaw merged commit e2b99f1 into nunit:master Dec 7, 2023
@manfred-brands manfred-brands deleted the issue4581_nuspec branch December 8, 2023 05:45
@Romfos

Romfos commented Jan 23, 2024

Copy link
Copy Markdown

could you please release hotfix with it?

@OsirisTerje

OsirisTerje commented Jan 23, 2024

Copy link
Copy Markdown
Member

@Romfos We have added it to the 4.1 milestone. You can add the package to your own projects as a workaround until 4.1 is out, right? Since that is easy to do, it doesn't require a hotfix.

We can have a 4.1. release by the end of February, but there are still a few open issues there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NUnit 4 needs System.Threading.Tasks.Extensions for net472 tests

4 participants