#4602 WpfMessagePumpStrategy

[soerendd]

Replace Dispatcher.Run with PushFrame as Dispatcher.Run needs to exit all frames to return properly which causes issues if there is already an outer frame.

Should fix #4602

[soerendd]

@dotnet-policy-service agree

[jnm2]

Thanks so much! LGTM

[jnm2]

If it's possible to write a test that fails for the previous strategy and succeeds here, that would be great.

[soerendd]

If it's possible to write a test that fails for the previous strategy and succeeds here, that would be great.

Sure thing. I checked if there is a test for the message pump strategies. There are none.

I will check where to add this test

[soerendd]

If it's possible to write a test that fails for the previous strategy and succeeds here, that would be great.

Sure thing. I checked if there is a test for the message pump strategies. There are none.

I will check where to add this test

@jnm2 I'm sorry but I haven't found a place where to put tests for that. The reason is that it would require a reference to System.Windows.Threading (wpf). Furthermore, I do not see an easy way to mock this properly.

[OsirisTerje]

@soerendd The builds fails due to a mismatch on sdks. This is fixed in the master branch, so if you just merge in the master branch and push that up, the builds should work just fine.

[soerendd]

@OsirisTerje Merged and pushed.