Skip to content

chore: Refer to global.json for SDK version #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

mikkelbu
Copy link
Member

@mikkelbu mikkelbu commented Jan 21, 2024

Fixes #4606

@mikkelbu mikkelbu force-pushed the chore/use-global-json branch from 53c04bb to e58fc5a Compare January 21, 2024 19:16
@mikkelbu mikkelbu force-pushed the chore/use-global-json branch from e58fc5a to 8fb74dc Compare January 21, 2024 19:18
@manfred-brands
Copy link
Member

We now no longer install .net 6.0 ourselves.
The tests pass because it is pre-installed on GitHub runners. Assuming this will stay the case while it is supported by MS I'm ok with this change.

Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OsirisTerje OsirisTerje merged commit 0f73682 into master Jan 22, 2024
@OsirisTerje OsirisTerje deleted the chore/use-global-json branch January 22, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions fail on master for Windows and Linux builds
3 participants