-
Notifications
You must be signed in to change notification settings - Fork 747
Add support for DateTime comparison with TimeSpan tolerance #4618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I had to pull out the test data into a source method because Also, unlike the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RenderMichael.
The code changes are nice and simple.
However as it also affects other areas where Tolerance
is used, could you also please update the other constraint tests: GreaterThanOrEqualConstraintTests
, LessThanConstraintTests
and LessThanOrEqualConstraintTests
by adding use cases for TimeSpan
.
Thanks for the feedback @manfred-brands The PR has been updated, I also added an equality test to the existing Greater Than tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @RenderMichael for adding those extra tests.
Nothing more from me.
Sorry for the update after the fact, I noticed I used some terrible variable names in the tolerance method. Fixed with no functional changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @RenderMichael ! Appreciate the final cleanup you did too :)
I'm going to try converting this to a draft and back to see if it un-sticks the WIP check |
@OsirisTerje The WIP check seems stuck here and I don't seem to be able to override the merge. Are you able to help? |
@stevenaw Merged. |
Thanks @OsirisTerje |
Fixes #4600