Add Prefix in TestContext.AddTestAttachment for long file paths#4665
Merged
Conversation
Contributor
Author
@dotnet-policy-service agree |
Member
|
Thanks for your contribution @Meet2rohit99 |
Contributor
Author
Thanks @stevenaw! Added test. |
…rk in TestContextTests.cs
manfred-brands
requested changes
Mar 18, 2024
manfred-brands
approved these changes
Mar 18, 2024
Member
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks. Looking good now. Builds are all green.
stevenaw
approved these changes
Mar 19, 2024
Member
stevenaw
left a comment
There was a problem hiding this comment.
Thanks for your contribution @Meet2rohit99 ! This looks good to me too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4353.
For .NetFramework, with file path greater than 260, TestContext.AddTestAttachment was throwing attachment not found exception. As suggested prefixing "\\?\" with absolute path works fine. The issue is with .NET Framework variants but not on .NET Core3.1, .NET6, or .NET7. Therefore adding prefix only in case of .NetFramework