Skip to content

PropertiesComparer: Show actual property and value that fails equality - #4712

Merged
manfred-brands merged 2 commits into
masterfrom
issue4710_ImprovePropertiesComparerMessage
May 20, 2024
Merged

manfred-brands merged 2 commits into
masterfrom
issue4710_ImprovePropertiesComparerMessage

Conversation

@manfred-brands

Copy link
Copy Markdown
Member

Fixes #4710

@manfred-brands
manfred-brands force-pushed the issue4710_ImprovePropertiesComparerMessage branch from da135ab to 69a8685 Compare May 15, 2024 14:44

@OsirisTerje OsirisTerje left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small nitpicks.

And, consider the nulls.

@OsirisTerje

Copy link
Copy Markdown
Member

@manfred-brands merge ?

@manfred-brands
manfred-brands merged commit f412649 into master May 20, 2024
@manfred-brands
manfred-brands deleted the issue4710_ImprovePropertiesComparerMessage branch May 20, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve PropertiesComparer diagnostics

2 participants