PropertiesComparer: Show actual property and value that fails equality #4712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manfred-brands
force-pushed
the
issue4710_ImprovePropertiesComparerMessage
branch
from
da135ab to
69a8685
Compare
OsirisTerje
approved these changes
May 16, 2024
Member
OsirisTerje
left a comment
OsirisTerje
left a comment
There was a problem hiding this comment.
Looks good, a few small nitpicks.
And, consider the nulls.
src/NUnitFramework/framework/Constraints/EqualConstraintResult.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Constraints/Comparers/PropertiesComparer.cs
Outdated
Show resolved
Hide resolved
Member
|
@manfred-brands merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4710