Add clearer documentation to custom comparers, fill testing holes. #4729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenderMichael
commented
Jun 12, 2024
manfred-brands
requested changes
Jun 12, 2024
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Only some small issues.
src/NUnitFramework/framework/Constraints/CollectionSupersetConstraint.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Constraints/SomeItemsConstraint.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
PR feedback addressed, the only remaining thing is nunit/docs#937 (comment), since its resolution affects this PR. |
manfred-brands
requested changes
Jun 18, 2024
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
One rename of Type parameter and one rename of method parameters.
src/NUnitFramework/tests/Constraints/DictionaryContainsValueConstraintTests.cs
Outdated
Show resolved
Hide resolved
src/NUnitFramework/framework/Constraints/DictionaryContainsValueConstraint.cs
Outdated
Show resolved
Hide resolved
manfred-brands
approved these changes
Jun 18, 2024
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @RenderMichael. Nothing further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4726
Following the advice of @manfred-brands:
I took the opportunity to find every instance of the in-line comparers to clear things up.
I dropped the
Typeat the end of the the generic parameter names because it began to feel too verbose, I'll add it back in if that's the preferred convention.Some of the more pathological cases had testing holes so I filled those in as well.