Skip to content

Generic test case attribute#4755

Merged
OsirisTerje merged 2 commits intonunit:mainfrom
manfred-brands:GenericTestCaseAttribute
Jul 12, 2024
Merged

Generic test case attribute#4755
OsirisTerje merged 2 commits intonunit:mainfrom
manfred-brands:GenericTestCaseAttribute

Conversation

@manfred-brands
Copy link
Member

@manfred-brands manfred-brands commented Jul 11, 2024

Fixes #4632

Add support for:

  • [TestCase<double>(2)]
  • new TestCaseData<double>(2)

Both support up to 5 generic arguments.

@manfred-brands manfred-brands requested a review from stevenaw July 11, 2024 05:07
@OsirisTerje
Copy link
Member

OsirisTerje commented Jul 11, 2024

Seems to be a small timing issue on the Linux build. The time limit is set to 100 mS, actual is 125 mS. So Linux is slower.....

But the 100mS is a hardcoded limit, is this meant to be really faster, so this is just a high limit, or are there something behind this ?

@manfred-brands
Copy link
Member Author

Seems to be a small timing issue on the Linux build. The time limit is set to 100 mS, actual is 125 mS. So Linux is slower.....

But the 100mS is a hardcoded limit, is this meant to be really faster, so this is just a high limit, or are there something behind this ?

Nothing in this PR affected this.
Maybe there is a difference with the runner we get now.
slower or with less memory. i think we had to disable the time test for MacOs.

@OsirisTerje
Copy link
Member

i think we had to disable the time test for MacOs.

Yes, we can do the same here, or increase the timeout. Whatever.

@manfred-brands
Copy link
Member Author

Triggered a re-build, it is green now.

Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic TestCase and TestCaseParameter support

2 participants