Merged
Conversation
stevenaw
force-pushed
the
4651-fix-filter-parsing
branch
from
fe1cd68 to
9840405
Compare
stevenaw
changed the title
Member
Author
|
This is ready for review |
src/NUnitFramework/tests/Internal/Filters/TestFilterXmlTests.cs
Outdated
Show resolved
Hide resolved
| { | ||
| if (reader.Depth < parents.Count) | ||
| { | ||
| parents.Pop(); |
Member
There was a problem hiding this comment.
Does this mean that the code that 'Pops' in lines 153-157 can be removed?
Member
Author
There was a problem hiding this comment.
Good point! I recall that code being hit, but it was before having added my own changes. I'll try and check this out tonight to confirm if it can be removed.
Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
Member
Author
|
Thanks @manfred-brands ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4651
Fixes #4589
First commit is just to establish a baseline failing CI run with the two known scenarios. Second commit fixes the underlying issue.