Test selection issue with normalized newlines#4773
Conversation
manfred-brands
force-pushed
the
4584-selection-issue
branch
2 times, most recently
from
af94ab4 to
f43e62c
Compare
manfred-brands
force-pushed
the
4584-selection-issue
branch
from
f43e62c to
1b3b1cc
Compare
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Your fix makes the code compatible with v3 with the minimum amount of changes.
| return display; | ||
| } | ||
|
|
||
| public static string EscapeControlChars(string s) |
There was a problem hiding this comment.
@manfred-brands Was this still needed? I don't see it referenced.
EDIT: Oh, sorry, I see it's used in the test you added. Just seeking clarity then, did you mean to add it here instead of in the tests in order to serve as a helper for others?
There was a problem hiding this comment.
@stevenaw I added it initially to allow escaping characters for all TestNames. Similar like what is done in case the parameter is a string. As we haven't decided on an approach, I added a commit to remove it.
That allows this branch to be merged and 4.2 to be released.
There was a problem hiding this comment.
Thanks @manfred-brands . Definitely nice to get this merged in case it's blocking others from upgrading
| public class Issue4584 | ||
| { | ||
| [Test] | ||
| public void DiscoverAndExecution() |
stevenaw
changed the title
2 participants
Fixes #4584
An initial pass to turn off line ending normalization while we decide on final approach. Still room for improvement and optimizations