Skip to content

Moved Windows specific SynchronizationContextTests to separate Windows project.#4776

Merged
manfred-brands merged 2 commits intonunit:mainfrom
manfred-brands:Issue3757_WindowsSynchronizationContext
Aug 18, 2024
Merged

Moved Windows specific SynchronizationContextTests to separate Windows project.#4776
manfred-brands merged 2 commits intonunit:mainfrom
manfred-brands:Issue3757_WindowsSynchronizationContext

Conversation

@manfred-brands
Copy link
Member

Fixes #3757

Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find on a simple fix here @manfred-brands . Changes look ok to me, and I can see in CI that 140/140 windows-specific tests are passing on NET6, NET8, and now net462 as well

@stevenaw
Copy link
Member

@manfred-brands
These changes look good to me and all the tests appear to pass. It's still marked as a WIP/draft, was there any more you wanted to do here?

@manfred-brands manfred-brands changed the title WIP: Moved Windows specific SynchronizationContextTests to separate Windows project. Moved Windows specific SynchronizationContextTests to separate Windows project. Aug 18, 2024
@manfred-brands manfred-brands marked this pull request as ready for review August 18, 2024 04:24
@manfred-brands manfred-brands merged commit fd76945 into nunit:main Aug 18, 2024
@manfred-brands manfred-brands deleted the Issue3757_WindowsSynchronizationContext branch December 27, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-Add WinForms and WPF based tests

2 participants