Make DelayedConstraint work with ThrowsContraint - #4815
Merged
Conversation
manfred-brands
approved these changes
Sep 6, 2024
manfred-brands
left a comment
manfred-brands
left a comment
Member
There was a problem hiding this comment.
@Dreamescaper Thanks. Looks good and a simple change.
stevenaw
approved these changes
Sep 6, 2024
stevenaw
left a comment
stevenaw
left a comment
Member
There was a problem hiding this comment.
Thanks for spotting this and contributing the fix @Dreamescaper !
I agree, the change in behaviour here is correcting an unwanted one (a bug) which is a good thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4281.
Previously, DelayedConstraint would execute the delegate by itself. However, underlying contraints might have additional logic for delegate handling - like ThrowsConstraint, which catches the exception.
Therefore, the fix is to pass the delegate to the constraint instead of executing it.
This fix has a change in the behavior. Currently, the test would fail if the delegate throws an exception. Now, since the delegate is invoked inside of try-catch block, it would be retried (for all constraints, not only Throws ones).
In my opinion, that's an expected behavior.
Still, let me know if you have any concerns.