Compare records by properties when requested#4837
Merged
manfred-brands merged 2 commits intonunit:mainfrom Sep 25, 2024
Merged
Conversation
manfred-brands
requested changes
Sep 25, 2024
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
We should assume that the owner of the class knows best. If it explicitly implements Equals(T) it should be called regardless of properties comparer selection.
Also for 90% of record classes which only contain value like properties the generated code is just fine.
Dreamescaper
commented
Sep 25, 2024
Member
Author
|
I've updated the PR per your suggestions, thanks! |
manfred-brands
approved these changes
Sep 25, 2024
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @Dreamescaper, looks good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4836 .
If CompareProperties is true, and actual value is record type, I ignore compiler-generated Equals methods, and force it to compare by properties instead.
In order to check that provided type is record, I verify that Equals method has CompilerGeneratedAttribute. Not sure if there's a better way.
I wanted to add a test for class with primary constructor, therefore I increased LangVersion to 12. Let me know if that causes any issues.