Fix IsEquivalent on default ImmutableArray throws exception#4850
Merged
Conversation
- Added an early return at the Matches method to handle cases where the actual collection is default (uninitialized) ImmutableArray. (#3772)
Member
|
Could you please add a test for a case when two default ImmutableArrays are compared? |
stevenaw
approved these changes
Oct 5, 2024
stevenaw
left a comment
stevenaw
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for your contribution @mr-sergito !
@jnm2 an oversight on my part during our discussion in the issue is how that the current lack of generic support in this constraint makes it harder to use EqualityComparer<T>.Default here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue (#3772) when trying to compare equivalency of two
default(ImmutableArray)s.Added an early return at the
Matchesmethod so that any test which passesEqualityComparer<T>.Default.Equalsalso passesIs.EquivalentTo().