Added StopOnFailure Parameter to RepeatAttribute
#4864
Conversation
|
@dotnet-policy-service agree company="Sparks Solutions GmbH" |
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @cfuerbachersparks. The actual change to functionality and tests looks good.
I have 2 requests for changes, see individual comments.
| /// <param name="count">The number of times to run the test</param> | ||
| public RepeatAttribute(int count) : base(count) | ||
| /// <param name="stopOnFailure">Whether to stop when a test is not successful or not</param> | ||
| public RepeatAttribute(int count, bool stopOnFailure = true) : base(count) |
There was a problem hiding this comment.
This is non-backward change for already compiled code. You need to keep the original constructor, it can call the new ones. This also means you have to make the stopOnFailure parameter non-optional in the new constructor.
Personally, I prefer a syntax where I can say: [Repeat(5, StopOnFailure = true)] as a clear indication what the boolean means. You can add a StopOnFailure property so users can choose which way they prefer.
There was a problem hiding this comment.
made StopOnFailure a property, restored old ctor and created a new one with non-optional parameter
…one with non-optional parameter
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @cfuerbachersparks.
One more item, can you add a unit test which uses the attribute and sets the StopOnError property, one each for false and true
added two unit tests |
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Sorry for the delay. Looks good now.
2 participants
Changes to always repeat a test x times.
Fixes #4861.