4862: Remove Property Limit From PropertiesComparer#4870
Merged
OsirisTerje merged 1 commit intoNov 3, 2024
Conversation
…retrying without tolerance.
manfred-brands
approved these changes
Nov 2, 2024
manfred-brands
left a comment
manfred-brands
left a comment
Member
There was a problem hiding this comment.
@Cincidial Thanks for you contribution.
The changes look nice and simple.
I don't think it makes sense to make extension methods for the two missing methods.
These methods would have to iterate over all bits twice (All and Any) when it is simpler to maintain the count.
mikkelbu
approved these changes
Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PropertiesComparerto use a BitArray instead of a uint (only 32 bits).Note that in the docs for
BitArrayabove there are 2 methods which are only available from .NET 8 and onwards. As such they can't be used hereInstead of re-implementing these methods for use in this case, I opted to use a counter to count the properties that could not use the tolerance. If re-implementing these would be preferred let me know and I can add them in as extension methods?
Tests passed locally for Windows. I don't have another OS to test on.
Fixes #4862