Fixes #4876 - Tests with negative tolerance always fail without proper message#4881
Merged
stevenaw merged 2 commits intonunit:mainfrom Nov 8, 2024
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
stevenaw
approved these changes
Nov 8, 2024
Member
stevenaw
left a comment
stevenaw
left a comment
There was a problem hiding this comment.
LGTM as well. Thanks for your contribution @RaffaelCH !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4876
Currently executing a test with a negative Tolerance (e.g.,
Is.Equal.Within(-1)) leads to the test not passing without any errors. With these changes an ArgumentException is thrown at runtime instead.