Async Test continuations now also run on the same thread when SIngleThreaded is used.#4883
Merged
Conversation
stevenaw
approved these changes
Nov 11, 2024
Member
There was a problem hiding this comment.
LGTM thanks @manfred-brands !
I'll request @jnm2 here for review too if they're available.
Member
|
@manfred-brands @stevenaw Doesnt look like @jnm2 have time - so suggest we merge this "as is" . Lgtm. |
jnm2
approved these changes
Nov 25, 2024
2 tasks
manfred-brands
force-pushed
the
AsyncSingleThread
branch
from
d42e09d to
18f9331
Compare
Member
Author
|
@OsirisTerje Are you ok for me to merge? |
Member
|
I'm merging this as the changes have been approved and we've identified this as something we'd like for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4110
If the
TestContext.IsSingleThreadedis set using the[SingleThreaded]attribute and an Async operation is executed a SingleThreadedSynchronizationContext is created.