Conversation
mikkelbu
left a comment
There was a problem hiding this comment.
Looks good - only comments and questions from me 👍
| /* | ||
| /// <summary>Test fixture not found - No longer in use</summary> | ||
| //public const int FIXTURE_NOT_FOUND = -3; | ||
| */ |
There was a problem hiding this comment.
Perhaps we should rather remove this ?
| #if !NET8_0_OR_GREATER | ||
| using System.Runtime.Serialization; | ||
| #endif |
There was a problem hiding this comment.
Just suggestions. Should we move the usings outside the namespace? (and perhaps move System.Runtime.Serialization down to the sole purpose, so we avoid having two !NET8_0_OR_GREATER blocks ?
EDIT: I can see that we do it differently in many of the ...Exception files, so I'm also happy with the current solution (to keep the fix as small as possible)
| #if !NET6_0_OR_GREATER | ||
| using System.Security.Permissions; | ||
| #endif |
| #if !NET8_0_OR_GREATER | ||
| #if !NET6_0_OR_GREATER |
There was a problem hiding this comment.
Doesn't #if !NET6_0_OR_GREATER imply #if !NET8_0_OR_GREATER ?
Or is this to to anticipate when we remove the .NET6 target ?
OsirisTerje
left a comment
There was a problem hiding this comment.
We need to add the .net 8 bits to the nunit.nuspec file, otherwise the bits don't go into the nupkg.
8d80b76 to
64c5644
Compare
64c5644 to
14d6fee
Compare
Thanks @OsirisTerje I forgot and to ensure nobody will forget it again, I added a nunit test to verify proper file references in .nuspec files. The bulk of the size is the 3 copies of the .xml files 1.2MB per target. |
dce03fd to
1851cc7
Compare
|
Lgtm, @manfred-brands : can we merge ? |
Fixes #4890
Works toward #4857
This adds the .NET 8.0 target. So that if users that are not allowed to use end-of-life frameworks due to lack of security updates can the .NET8.0 binaries.