Conversation
stevenaw
approved these changes
Nov 25, 2024
Member
stevenaw
left a comment
stevenaw
left a comment
There was a problem hiding this comment.
Thanks @OsirisTerje
I suppose my initial hesitation to just bumping this was the unknown of if we would have to bump it again with the next release of System.Memory. That said, it's been about 2 years between releases for System.Memory, and 6 years since the last minor version bump (if that factors in) so perhaps that is a problem for another time
Member
|
@OsirisTerje I'm going to go ahead and merge this as well as both @manfred-brands and I have approved. Thanks again for your fix here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4887