Fix test error in TestContextOneTimeTearDownTests - #4928
Conversation
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Looks good to me.
It proves that the result in the OneTimeTearDown matches the overall result.
| Assert.That(tearDownResult, Is.Not.Null); | ||
| Assert.Multiple(() => | ||
| { | ||
| Assert.That(tearDownResult!.Outcome, Is.EqualTo(result.ResultState)); |
There was a problem hiding this comment.
You shouldn't need the null suppression operator !.
There was a problem hiding this comment.
I can try to take a closer look at this one tomorrow. I had added it to suppress a warning, but I can also try updating the referenced version of the analyzer package. I think I saw that we currently reference 4.3.0 whereas latest is 4.6.0
There was a problem hiding this comment.
Aha. Appears I was still a few bugfix versions behind on Visual Studio. I've upgraded to latest and now no longer need the !. Thanks for pointing that out!
I've pushed the change to remove it and will merge once the builds pass
2 participants
Fixes #4906
Re: my "filter" comments in the issue. I wasn't able to see anything of note based on an initial look.