Skip to content

Fix DelayedConstraint calling delegates at double the rate. - #4929

Merged
manfred-brands merged 4 commits into
mainfrom
Issue2841_DelayedConstraint
Feb 17, 2025
Merged

manfred-brands merged 4 commits into
mainfrom
Issue2841_DelayedConstraint

Conversation

@manfred-brands

Copy link
Copy Markdown
Member

Fixes #2841

@manfred-brands

Copy link
Copy Markdown
Member Author

Not sure what goes on with these build agents:

Assert.That(list.PollCount, Is.LessThanOrEqualTo(10 + 1))
  Expected: less than or equal to 11
  But was:  576

This could only happen if the Stopwatch doesn't increase and the Thread.Sleep doesn't actually sleep.

This to try to fix the extra iterations seen on github runners.
@manfred-brands

Copy link
Copy Markdown
Member Author

I don't like my hack for the github runners.
Maybe I missed something.

@stevenaw

stevenaw commented Feb 9, 2025 •

Copy link
Copy Markdown
Member

@manfred-brands The last few weeks have been busy for me, but I'll try to get a review in of this in the coming days now that I've got a bit more time.

@stevenaw
stevenaw self-requested a review February 9, 2025 11:40
@stevenaw

Copy link
Copy Markdown
Member

Thanks @manfred-brands . Changes themselves look good. Odd about the github runner. It looks like the run before adding that explicit loop only failed on linux, and the build came with a notice that ubuntu-latest would soon change to 24.02. That change has since happened so I'm going to try pushing a test branch with your last commit removed to see if that works now.

@stevenaw stevenaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that last commit is still needed for GH runners to pass. I don't have any concerns with this PR as-is, however I'll abstain from merging myself in case someone else wants to take a look.
@manfred-brands feel free to merge as well if you're satisfied

@manfred-brands
manfred-brands merged commit efb218b into main Feb 17, 2025
@manfred-brands
manfred-brands deleted the Issue2841_DelayedConstraint branch February 17, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DelayedConstraint calls delegate twice

2 participants