Skip to content

Mark ApplyTo<TActual>(ref TActual actual) as obsolete#4944

Merged
OsirisTerje merged 1 commit into
mainfrom
Issue4930_ApplyRef
Mar 1, 2025
Merged

Mark ApplyTo<TActual>(ref TActual actual) as obsolete#4944
OsirisTerje merged 1 commit into
mainfrom
Issue4930_ApplyRef

Conversation

@manfred-brands
Copy link
Copy Markdown
Member

Fixes #4930

Copy link
Copy Markdown
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @manfred-brands . I've left a small optional suggestion for what I think may be clearer wording.

Comment thread src/NUnitFramework/framework/Constraints/IConstraint.cs Outdated
Comment thread src/NUnitFramework/framework/Constraints/Constraint.cs Outdated
@manfred-brands
Copy link
Copy Markdown
Member Author

@OsirisTerje Can we do something about the MacOS build? Why would a NuGet package download fine on WIndows/Linux but not on MacOS? Do we even need to sign just to test?

@mikkelbu
Copy link
Copy Markdown
Member

mikkelbu commented Mar 1, 2025

@OsirisTerje Can we do something about the MacOS build? Why would a NuGet package download fine on WIndows/Linux but not on MacOS? Do we even need to sign just to test?

I've made a temporary fix that removes installing sign from the MacOs workflow - see #4950

@OsirisTerje OsirisTerje merged commit 5d44223 into main Mar 1, 2025
@OsirisTerje OsirisTerje deleted the Issue4930_ApplyRef branch March 1, 2025 23:27
@OsirisTerje
Copy link
Copy Markdown
Member

@manfred-brands Sorry - I am out travelling, currently in Australia :-) North of Brisbane. But I see @mikkelbu has removed the signing on mac (good).

You say that the package may not work on Mac ?

Isn't it only the build that fails? The package should be identical for all targets.

@manfred-brands
Copy link
Copy Markdown
Member Author

@manfred-brands Sorry - I am out travelling, currently in Australia :-) North of Brisbane. But I see @mikkelbu has removed the signing on mac (good).

There is still a lot of Australia north of Brisbane, but I presume you are at the sunshine coast (Noosa). Enjoy.

You say that the package may not work on Mac ?

Isn't it only the build that fails? The package should be identical for all targets.

I wondered why the same package is fine on Windows/Linux and not on MacOS.

@stevenaw
Copy link
Copy Markdown
Member

stevenaw commented Mar 2, 2025

I have to wonder if an update to the Mac image has compatibility issues.

It looks like macos-latest was last updated Jan 20 based on https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md
Anecdotally (as I can't view the build history at the moment) I think I remember the first set of changes to PR #4925 passing when the PR was first made on Jan 17

@mikkelbu
Copy link
Copy Markdown
Member

mikkelbu commented Mar 2, 2025

I have to wonder if an update to the Mac image has compatibility issues.

It looks like macos-latest was last updated Jan 20 based on https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md Anecdotally (as I can't view the build history at the moment) I think I remember the first set of changes to PR #4925 passing when the PR was first made on Jan 17

So far I've not seen any other reports of this issue (but I've not done a thorough search). I tried bumping to macos-15 in #4949, but that also failed. As far as I can tell we started seeing these kind of errors on Feb 15 - https://github.com/nunit/nunit/actions/runs/13346353761

It also seems like the macos-14 image was updated on Jan 20 (see image - from https://github.com/nunit/nunit/actions/runs/13610136540/job/38046197396 -
image

But either signature expired a long time ago
image

(But I don't think I'll spend more time on this now :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What to do with IConstraint.Apply<TActual>(ref TActual)

4 participants