Treat an exception as an assertion failure and always add it to the assertion list. - #4979
Merged
Merged
Conversation
OsirisTerje
requested changes
Apr 20, 2025
OsirisTerje
left a comment
OsirisTerje
left a comment
Member
There was a problem hiding this comment.
Just commented on some smaller coding stuff.
The change seems to hit rather large, but seems to be well covered by the tests.
OsirisTerje
approved these changes
Apr 22, 2025
manfred-brands
force-pushed
the
Issue4537_ExceptionsAreAssertionFailures
branch
from
April 25, 2025 02:12
7eb206f to
7e75b20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4537
There is a change in
RepeatAttributebehaviour:StopOnFailureis false, the test continues executing.The above are side effects of #4861 and only affect the code when
StopOnFailureis set to false.