Repository navigation
DictionaryContainsKeyConstraint no longer derives from CollectionItemsEqualConstraint - #4989
Conversation
…sEqualConstraint Now we no longer get `IgnoreCase` options that don't work. It hasn't used that functionality for 6+ years.
mikkelbu
left a comment
mikkelbu
left a comment
There was a problem hiding this comment.
Looks good and as far as I can tell the class is covered by tests, so I think this is a fine fix
| /// contains an expected object as a key. | ||
| /// </summary> | ||
| public class DictionaryContainsKeyConstraint : CollectionItemsEqualConstraint | ||
| public class DictionaryContainsKeyConstraint : Constraint |
There was a problem hiding this comment.
I guess we need an update to the docs as it has DictionaryContainsKeyConstraint under Collection Constraints in https://github.com/nunit/docs/blob/a844b0a9592a49f29e3a5bfb3a0083f375b29790/docs/articles/nunit/writing-tests/constraints/Constraints.md?plain=1#L85
There was a problem hiding this comment.
It is still a constraint on the collection of keys, it just doesn't derive from the class CollectionConstraint anymore.
That note only shows category not class. So I think that part is fine.
I will create a PR to update DictionaryContainsKeyConstraint.md to remove the no longer available constraints.
3 participants
Fixes #4981
Now we no longer get
IgnoreCaseetc., options that don't work.It hasn't used that functionality for 6+ years.