New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultTestNamePattern doesn't work with Live Unit Testing #375

Closed
OsirisTerje opened this Issue Aug 12, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@OsirisTerje
Member

OsirisTerje commented Aug 12, 2017

NUnit 3.7.1
NUnit3TestAdapter 3.8.0
Visual Studio 2017 (15.2.26430.12)
Targeting .net framework 4.5.2
Given a test like:
image

If I add a default test name pattern to a runsettings file, like
image
which results in the test being displayed like this in the test explorer:
image
If I then enable Live Unit Testing, then the test name is repeated twice
image

If I remove the runsettings again, but instead uses the TestName property like
image
it works as it should.

It seems the LUT doesn't get the default test name pattern for its run. The settings are being loaded for both discovery and execution, so I can't see the adapter is doing anything wrong here, is there something in NUnit itself that might cause this? @CharliePoole @rprouse ?

@CharliePoole

This comment has been minimized.

Show comment
Hide comment
@CharliePoole

CharliePoole Aug 12, 2017

Member

Looks like a bug in LUT.

Member

CharliePoole commented Aug 12, 2017

Looks like a bug in LUT.

@OsirisTerje

This comment has been minimized.

Show comment
Hide comment
@OsirisTerje

OsirisTerje Aug 12, 2017

Member

@codito, comment ?

Member

OsirisTerje commented Aug 12, 2017

@codito, comment ?

@ManishJayaswal

This comment has been minimized.

Show comment
Hide comment
@ManishJayaswal

ManishJayaswal Aug 14, 2017

LUT at this time does not use settings from the runsettings file much ( except for finding the adapters). Additionally the integration of LUT with the test explorer window needs more polish ( which is the reason you see both when LUT is on). We have both in our backlog and intend to address them holistically.

ManishJayaswal commented Aug 14, 2017

LUT at this time does not use settings from the runsettings file much ( except for finding the adapters). Additionally the integration of LUT with the test explorer window needs more polish ( which is the reason you see both when LUT is on). We have both in our backlog and intend to address them holistically.

@OsirisTerje

This comment has been minimized.

Show comment
Hide comment
@OsirisTerje

OsirisTerje Aug 14, 2017

Member

Thanks Manish for the explanation!
Then I'll close this here.
Hope you have this fixed on your side soon :-)

Member

OsirisTerje commented Aug 14, 2017

Thanks Manish for the explanation!
Then I'll close this here.
Hope you have this fixed on your side soon :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment