Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less verbose printer #99

Closed
robsontenorio opened this issue Mar 10, 2020 · 12 comments
Closed

Less verbose printer #99

robsontenorio opened this issue Mar 10, 2020 · 12 comments

Comments

@robsontenorio
Copy link

robsontenorio commented Mar 10, 2020

It would be nice to have a less verbose option. Just that "dots", but keep the "beauty error handler".

@nunomaduro
Copy link
Owner

Ideas on this?

@robsontenorio
Copy link
Author

Just for clarifying.

Allow to use this output, but keep the collision error hanlder.

image

@nunomaduro
Copy link
Owner

I think we do better than that.

@nunomaduro nunomaduro changed the title Less verbose option Less verbose printer May 11, 2020
@robsontenorio
Copy link
Author

robsontenorio commented May 22, 2020

Sometimes you just want a overview of tests (with "dots" report), but also a nice error handler output.

Once collision is a "printer" i really don't know if it would be possible to configure through params. But if so, i am willing to submit a PR.

@nunomaduro
Copy link
Owner

@AlexMartinFR is working on that.

@zembrowski
Copy link

@mikeerickson does a great job with phpunit-pretty-result-printer. The output is very minimalistic.

The only thing missing there is an integration with Collision. It would be a perfect match to get phpunit-pretty-result-printer with your collision error handler, Nuno.

Any chances to get back the Listener which was removed in v4.1?

@jaggy
Copy link

jaggy commented Dec 27, 2020

Hi there! I just wanted to show interest in this issue as well.

Using php artisan test seems to be a bit slower (35s) than using phpunit's default printer (16s). I'm not sure if it's related with the printer but it's the only connecting thread I see.

@mikeerickson
Copy link

@zembrowski @jaggy @robsontenorio keep your eyes pealed for an upcoming release of printer which will have something similar to previous listener integrated with phpunit-pretty-result-printer

@nunomaduro nunomaduro mentioned this issue Dec 27, 2020
15 tasks
@mikeerickson
Copy link

@AlexMartinFR Is this something that is still on your radar, or have you ditched the plans? If this is still no your radar, that would be fantastic.

@nunomaduro
Copy link
Owner

@mikeerickson I will probably tackle this myself before PEST v1, and before Laravel 9.

@AlexMartinFR
Copy link
Contributor

Great new Nuno 👍

I've hit roadblocks when I tried to implement it properly, and haven't had a chance to try again yet.
Would it help if I shared what I tried and what I was stuck on?

@mikeerickson
Copy link

@nunomaduro was this implemented or did you decide to drop it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants