Default value of checkOctaneCompatibility

[bytestream]

• Larastan Version: 6.20.36
• --level used: 8

Description

Upgrading from v0.7.13 to v0.7.14 produces:

Consider using bind method instead or pass a closure.            
 💡 See: https://laravel.com/docs/octane#dependency-injection-and-octane  

The default is supposed to be off. I suspect it's occurring due to changes to extension.neon in c7e41a8

[szepeviktor]

@bytestream Hello!

Isn't it already false?

https://github.com/nunomaduro/larastan/blob/7d6e564144b2f9c231d0331d4083905a1b3e872b/extension.neon#L47

[canvural]

Hi,

Default value is still off. I tested in a couple of projects, and it seems fine.

[bytestream]

@canvural Sorry I should have provided a reproducer. Try using the below - it's reproducable in a fresh laravel 6 install with the below

<?php declare(strict_types=1);

namespace App\Providers;

use Illuminate\Support\Manager;
use Illuminate\Support\ServiceProvider;

class WidgetServiceProvider extends ServiceProvider
{
    public function register(): void
    {
        $this->app->singleton('core.plugins.widgetFactory', function () {
            return $this->app->make(Manager::class)->driver('widget');
        });
    }
}

includes:
    - ./vendor/nunomaduro/larastan/extension.neon

parameters:
    level: 8
    paths:
        - app/Providers/WidgetServiceProvider.php

$ ./vendor/bin/phpstan analyse
Note: Using configuration file /larastan-test/phpstan.neon.dist.
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------ 
  Line   WidgetServiceProvider.php                                               
 ------ ------------------------------------------------------------------------ 
  13     Consider using bind method instead or pass a closure.                   
         💡 See: https://laravel.com/docs/octane#dependency-injection-and-octane  
 ------ ------------------------------------------------------------------------ 

                                                                                                                   
 [ERROR] Found 1 error                                                                                             
                                                                                                                  

Switch back:

$ composer require nunomaduro/larastan:0.7.13 --dev
./composer.json has been updated
Running composer update nunomaduro/larastan
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Downgrading nunomaduro/larastan (v0.7.14 => v0.7.13)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Downloading nunomaduro/larastan (v0.7.13)
  - Downgrading nunomaduro/larastan (v0.7.14 => v0.7.13): Extracting archive
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
Discovered Package: facade/ignition
Discovered Package: fideloper/proxy
Discovered Package: laravel/tinker
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Package manifest generated successfully.
78 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

$ ./vendor/bin/phpstan analyse
Note: Using configuration file /larastan-test/phpstan.neon.dist.
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                   
 [OK] No errors                                                                                                    
                                                                                                                   

[szepeviktor]

Where is Octane in it??

[bytestream]

Where is Octane in it??

What do you mean? I'm not using Octane.

[canvural]

Oh I see the error. c7e41a8 added tags to rules in extension.neon

Fix is easy but how to release it? 😅 We have changes in master that shouldn't be in the release.

Creating new branch from the 0.7.14 tag and release on that branch?

[szepeviktor]

Creating new branch from the 0.7.14 tag and release on that branch?

Yes!

[canvural]

Ok https://github.com/nunomaduro/larastan/releases/tag/v0.7.15 should fix the issue!

[bytestream]

Yep that did the trick. Thanks guys ❤️