Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Magento2 preset #102

Merged
merged 2 commits into from May 19, 2019

Conversation

@Jibbarth
Copy link
Collaborator

commented May 19, 2019

Q A
Bug fix? no
New feature? yes
Fixed tickets #36
@nunomaduro
Copy link
Owner

left a comment

🔥Sounds everything great! Can you also update the docs: https://github.com/nunomaduro/phpinsights/tree/master/docs?

@Jibbarth

This comment has been minimized.

Copy link
Collaborator Author

commented May 19, 2019

@nunomaduro I didn't see this new part, sorry. It's updated.

🤔 The complexity has been decreased by adding this Preset. Do you know how can I keep a correct level?

@nunomaduro nunomaduro merged commit 8e30089 into nunomaduro:master May 19, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 19, 2019

We shouldn't worry about decreased complexity here.

@nunomaduro

This comment has been minimized.

Copy link
Owner

commented May 19, 2019

Thanks for this!

@Jibbarth Jibbarth deleted the Jibbarth:feature/preset-magento2 branch May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.