Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Magento2 preset #102

Merged
merged 2 commits into from
May 19, 2019
Merged

Create Magento2 preset #102

merged 2 commits into from
May 19, 2019

Conversation

Jibbarth
Copy link
Collaborator

Q A
Bug fix? no
New feature? yes
Fixed tickets #36

nunomaduro
nunomaduro reviewed May 19, 2019
View reviewed changes
Copy link
Owner

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥Sounds everything great! Can you also update the docs: https://github.com/nunomaduro/phpinsights/tree/master/docs?

@Jibbarth
Copy link
Collaborator Author

@nunomaduro I didn't see this new part, sorry. It's updated.

🤔 The complexity has been decreased by adding this Preset. Do you know how can I keep a correct level?

@nunomaduro nunomaduro merged commit 8e30089 into nunomaduro:master May 19, 2019
@nunomaduro
Copy link
Owner

We shouldn't worry about decreased complexity here.

@nunomaduro
Copy link
Owner

Thanks for this!

@Jibbarth Jibbarth deleted the feature/preset-magento2 branch May 19, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jibbarth @nunomaduro